Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

update to latest lahja #917

Closed
wants to merge 1 commit into from
Closed

update to latest lahja #917

wants to merge 1 commit into from

Conversation

pipermerriam
Copy link
Member

@pipermerriam pipermerriam commented Aug 13, 2019 •
edited
Loading

What was wrong?

Latest lahja includes fixes that keep a number of errors out of the terminal during shutdown of endpoints.

How was it fixed?

Updated to latest lahja

To-Do

  • Clean up commit history

Cute Animal Picture

put a cute animal picture link inside the parentheses

@cburgdorf
Copy link
Contributor

I restarted CI but the error persists. We probably need to run git bisect on the recent lahja commits to figure out what's causing this.

@pipermerriam
Copy link
Member Author

Very odd. I'm able to reproduce these locally as well. Haven't dug in beyond looking at the diff between 0.14.0 and 0.14.1 but nothing jumped out that was obvious. Running with -l lahja=DEBUG doesn't give anything extra helpful either. Nothing from the server side indicating that a new connection attempt was made... Need to dig in.

@cburgdorf
Copy link
Contributor

I'm going to look into this now.

@cburgdorf
Copy link
Contributor

git bisect says the issues is that there was a timeout introduced that did not exist previously.

ethereum/lahja@66e2ecd#diff-80b7be955672ac86b8bad1b35ff46519R537

@cburgdorf
Copy link
Contributor

This PR would fix the issue ethereum/lahja#154

This was referenced Aug 27, 2019
Merged
Merged
@pipermerriam
Copy link
Member Author

replaced by #982

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cburgdorf cburgdorf Awaiting requested review from cburgdorf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pipermerriam @cburgdorf