This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Deduplicate CI jobs #1257
Merged
Deduplicate CI jobs #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipermerriam
approved these changes
Nov 7, 2019
This description looks inconsistent with the PR code. The tests are excluded from the pyxx-integration jobs, instead, right? (The in-PR way is my preference, since the wheel test is the most "true to final" integration test) |
|
@carver ah yeah, I wrote that down wrong in the PR description. The code has it right. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
We currently run the
trinity_clitests as part of thepyxx-wheel-clijobs as well as part of thepyxx-integrationjobs. This is wasting resources especially since these tests can sometimes be a little flaky.How was it fixed?
Exclude them from the
py-xx-integrationjobsCute Animal Picture