This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Store union of hashes for block witness #2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carver
changed the title
carver
force-pushed
the
witness-hash-union-2105
branch
from
613711a
to
1c2d53c
Compare
|
Sorry, I keep forgetting to review this. Will do so tomorrow, but just thought I'd mention I found a bug that causes Is that bug present in this branch as well? |
|
Yup, looks like that bug is fixed in this branch. I added the test. It's similar to another test I added, but seems good to have another explicit one. 👍 |
gsalgado
approved these changes
Nov 25, 2020
tests/core/p2p-proto/test_wit_db.py
Outdated
| """ | ||
| Repeated blocks should not consume more slots in the limited history of block witnesses | ||
| """ | ||
| wit_db = AsyncWitnessDB(AtomicDB()) |
There was a problem hiding this comment.
AsyncWitnessDB was changed recently to wrap a regular DatabaseAPI instead of AtomicDatabaseAPI, so we could use a MemoryDB() here instead
2 tasks
Atomic is not called for, anymore
Repeated persistence with the same block should not consume history slots. I tested the test by patching into line 59 of trinity/protocol/wit/db.py: + if True or block_hash not in recent_blocks_with_witnesses: The test fails with that change, as expected. Also, explicitly check that DB eviction works after a block repeat is persisted.
carver
force-pushed
the
witness-hash-union-2105
branch
from
14b6325
to
653f264
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Fixes #2105
How was it fixed?
Store union of the witness hashes, when witness metadata comes in for the same block.
To-Do
Test where two persists interleave their database accesses, to force the race condition that one witness overwrites the otherAdd a lock to pass ^ testAdd entry to the release notesCute Animal Picture