This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Upgrade cruft & fix a bunch of flaky tests #2124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
carver
added a commit
to carver/trinity
that referenced
this pull request
Mar 17, 2021
|
Oof this is ugly. For some reason connecting to the geth bootnodes crashes us right now 🙈 I suspect it's a whole eth/66 rabbit-hole. Well, it's at least two distinct problems:
|
|
More bad news: flaky tests in |
Also: - upgrade go version to v1.13 for geth build - uses --ropsten instead of --testnet in tests
... but issue a warning
They seem to crash us, maybe because eth/66 is unsupported. See the simplest `trinity` run on this test: tests/integration/test_trinity_cli.py:test_does_not_throw_errors_on_short_run
carver
added a commit
to carver/trinity
that referenced
this pull request
Mar 17, 2021
carver
added a commit
to carver/trinity
that referenced
this pull request
Mar 17, 2021
The py37-rpc-state-istanbul test is kind of flaky, with unclear cause (one of the worker threads just dies). Maybe it's a memory thing, or an old version of xdist thing? - Upgrade pytest-xdist to v1.34.0 - Reduce the number of worker threads from 3 to 2
The test was so short that a pretty small perturbation (>1ms) would cause a false failure. Now it needs at least a 5ms extrinsic delay to get a false failure.
Not convinced this really fixed it, but I think it gives extra time for
the logs to make it to the handler. Ideally, the server shouldn't shut
down until all the logs are passed on, but I couldn't confirm that with
a quick scan.
test_queued_logging failed once at:
with queue_listener.run(ipc_path):
assert len(handler.logs) == 0
proc.start()
proc.join()
> assert len(handler.logs) == 3
E assert 0 == 3
E + where 0 = len([])
E + where [] = <HandlerForTest (DEBUG)>.logs
Sometimes they seem to just cause a forever-hang. See: postlund/pyatv#904 This might make an uglier result when a timeout actually happens, but it's way better to have fewer false failure CI runs. Note that you can't put --forked into pytest.ini's addopts because we don't always have pytest-xdist installed (like in the wheel tests).
carver
changed the title
|
Trinity development is on-pause, at best. So yolo-merge it is... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Some things aren't building
How was it fixed?
Upgrade them to the latest. Probably just a code rot issue...
To-Do
Cute Animal Picture