Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Misc sync: state.deposit_index BLS-based RANDAO #286

Merged
merged 5 commits into from
Feb 18, 2019
Merged

Misc sync: state.deposit_index BLS-based RANDAO #286

merged 5 commits into from
Feb 18, 2019

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Feb 17, 2019 •
edited
Loading

What was wrong?

Fix #285

How was it fixed?

  1. Fields update
    1. BeaconState
      • Add deposit_index field
    2. DepositInput
      • Remove randao_commitment field
    3. BaseBeaconBlock
      • Change randao_reveal field from hash32 to binary (actually, bytes96 when we use SSZ)
    4. ValidatorRecord
      • Remove randao_commitment and randao_reveal fields
  2. Rename
    1. get_initial_beacon_state -> get_genesis_beacon_state
    2. initial_validator_deposits -> genesis_validator_deposits
  3. Remove outdated per-slot proposer.randao_layers and state.latest_randao_mixes update

Cute Animal Picture

flying-kangaroo
PanBK at the English language Wikipedia CC BY-SA 3.0

@hwwhww
Rename
4225dd6 
1. `get_initial_beacon_state` -> `get_genesis_beacon_state`
2. `initial_validator_deposits` -> `genesis_validator_deposits`
@hwwhww
Add BeaconState.deposit_index (ethereum/consensus-specs#594)
148e2c6
@hwwhww
Use BLS-based RANDAO types and modify process_deposit
c91f3ec
@hwwhww
Remove outdated per-slot proposer.randao_layers and `state.latest_r…
9451f49 
…andao_mixes` update
@hwwhww hwwhww added the eth2.0 label Feb 17, 2019
jannikluhn
jannikluhn approved these changes Feb 17, 2019
View reviewed changes
Copy link
Contributor

@jannikluhn jannikluhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

eth2/beacon/types/blocks.py Outdated Show resolved Hide resolved
@jannikluhn @hwwhww
Update eth2/beacon/types/blocks.py
b9ff4c4 
Co-Authored-By: hwwhww <hwwang156@gmail.com>
@hwwhww hwwhww merged commit caf9f38 into ethereum:master Feb 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jannikluhn jannikluhn jannikluhn approved these changes

Assignees
No one assigned
Labels
eth2.0 PR state: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misc spec sync for deposit and randao
2 participants
@hwwhww @jannikluhn