Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Move Eth2 plugins out of base plugins #715

Merged
merged 1 commit into from Jun 13, 2019
Merged

Move Eth2 plugins out of base plugins #715

merged 1 commit into from Jun 13, 2019

Conversation

cburgdorf
Copy link
Contributor

What was wrong?

The Two existing ETH2 plugins where in the set of base plugins which includes them for the Eth1 client and all other possible clients.

How was it fixed?

  • Moved them into its own set so that we have: base plugins, eth1 plugins, eth2 plugins
  • cleaned up imports a bit

To-Do

  • Clean up commit history

Cute Animal Picture

put a cute animal picture link inside the parentheses

@cburgdorf cburgdorf requested a review from hwwhww June 13, 2019 18:25
hwwhww
hwwhww approved these changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@cburgdorf cburgdorf merged commit 00acc52 into ethereum:master Jun 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hwwhww hwwhww hwwhww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cburgdorf @hwwhww