Allow external calls which return struct #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't guarantee that dynamic pack/unpacking will work, just allows it in the simple case.
jacqueswww
approved these changes
Apr 9, 2019
|
LGTM, maybe just add a test case for Nick Emmons code and we can merge it. |
jacqueswww
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't guarantee that dynamic pack/unpacking will work, just allows it
in the simple case.
What I did
Fix #1392
How I did it
Relax the case analysis in
get_external_contract_call_outputHow to verify it
Description for the changelog
Cute Animal Picture