Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web3.eth.Contract.getPastEvents doesn't support "allEvents" anymore #2316

Closed
mistersandman opened this issue Feb 3, 2019 · 0 comments · Fixed by #2332
Closed

web3.eth.Contract.getPastEvents doesn't support "allEvents" anymore #2316

mistersandman opened this issue Feb 3, 2019 · 0 comments · Fixed by #2332
Labels
Bug Addressing a bug In Progress Currently being worked on

Comments

@mistersandman
Copy link

mistersandman commented Feb 3, 2019

Expected behavior

Using "allEvents" as event name in web3.eth.Contract.getPastEvents should be accepted and return all events matching the specified options according to the docs.

Actual behavior

An exception "Error: Event with name "allEvents" does not exists." is thrown.

Steps to reproduce the behavior

Call getPastEvents on a contract with the first argument (event name) set to "allEvents".

Error Logs

Error: Event with name "allEvents" does not exists.
    at _callee$ (h:\****\node_modules\web3-eth-contract\dist\web3-eth-contract.cjs.js:959:28)
    at tryCatch (h:\****\node_modules\regenerator-runtime\runtime.js:62:40)
    at Generator.invoke [as _invoke] (h:\****\node_modules\regenerator-runtime\runtime.js:288:22)
    at Generator.prototype.(anonymous function) [as next] (h:\****\node_modules\regenerator-runtime\runtime.js:114:21)
    at asyncGeneratorStep (h:\****\node_modules\@babel\runtime\helpers\asyncToGenerator.js:3:24)
    at _next (h:\****\node_modules\@babel\runtime\helpers\asyncToGenerator.js:25:9)
    at h:\****\node_modules\@babel\runtime\helpers\asyncToGenerator.js:32:7
    at Promise (<anonymous>)
    at h:\****\node_modules\@babel\runtime\helpers\asyncToGenerator.js:21:12
    at h:\****\node_modules\web3-eth-contract\dist\web3-eth-contract.cjs.js:978:23
    at Promise (<anonymous>)
    at AbstractContract.getPastEvents (h:\****\node_modules\web3-eth-contract\dist\web3-eth-contract.cjs.js:949:14)

Versions

Observed on Windows 10 with NodeJS v8.1.2 using web3@1.0.0-beta.41.
This used to work on the same setup with web3@1.0.0-beta.37.

@nivida nivida added Bug Addressing a bug In Progress Currently being worked on labels Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Addressing a bug In Progress Currently being worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants