Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop JSON RPC errors from breaking websocket provider onmessage logic #1856

Merged
merged 1 commit into from
Aug 10, 2018
Merged

Stop JSON RPC errors from breaking websocket provider onmessage logic #1856

merged 1 commit into from
Aug 10, 2018

Conversation

daffl
Copy link
Contributor

@daffl daffl commented Aug 8, 2018 •
edited
Loading

JSON RPC errors do not include a method property so we had to add an additional check in the websocket provider to not cause unnecessary errors.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.841% when pulling 577b80b on bidalihq:jsonrpc-error into 9bf5803 on ethereum:1.0.

@coveralls
Copy link

coveralls commented Aug 8, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.08%) to 83.921% when pulling 577b80b on bidalihq:jsonrpc-error into 9bf5803 on ethereum:1.0.

@frozeman frozeman merged commit 44a3030 into web3:1.0 Aug 10, 2018
@daffl daffl deleted the jsonrpc-error branch August 10, 2018 22:39
nachomazzara pushed a commit to nachomazzara/web3.js that referenced this pull request Jun 4, 2020
@daffl @nachomazzara
Stop JSON RPC errors from breaking websocket provider onmessage logic (…
361804e 
…web3#1856)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frozeman frozeman frozeman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daffl @coveralls @frozeman @ekryski