Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract calls should return a BigNumber object #2568

Merged
merged 4 commits into from
Mar 25, 2019
Merged

Contract calls should return a BigNumber object #2568

merged 4 commits into from
Mar 25, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Mar 25, 2019

Description

Not a string should be returned on a contract call it should return the BigNumber object we have.

Fixes #2570

Type of change

  • Enhancement

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

@nivida nivida added Bug Addressing a bug In Progress Currently being worked on labels Mar 25, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.733% when pulling 26e12d8 on issue/2562 into f3bc100 on 1.0.

@nivida nivida added Enhancement Includes improvements or optimizations and removed Bug Addressing a bug labels Mar 25, 2019
@nivida nivida changed the title CoerceFunc for the AbiCoder fixed for production build Contract calls should return a BigNumber object Mar 25, 2019
@nivida nivida removed the In Progress Currently being worked on label Mar 25, 2019
@nivida nivida merged commit d7f5a80 into 1.0 Mar 25, 2019
@nivida nivida deleted the issue/2562 branch March 25, 2019 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Includes improvements or optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants