Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npm and deps badges to package READMEs #3444

Merged
merged 4 commits into from
Apr 6, 2020
Merged

Conversation

ryanio
Copy link
Collaborator

@ryanio ryanio commented Mar 31, 2020

Description

I noticed using david-dm.org for the root repository is not so useful since the lerna structure has no deps in root (only devDeps), so this PR adds npm and deps badges to individual package READMEs.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I have executed npm run test:cov and my test cases do cover all lines and branches of the added code.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@ryanio ryanio changed the title Add npm and deps README badges to packages Add npm and deps badges to package READMEs Mar 31, 2020
@coveralls
Copy link

coveralls commented Mar 31, 2020

Coverage Status

Coverage remained the same at 86.048% when pulling e73e82e on addPackageReadmeBadges into 67ea9d0 on 1.x.

Copy link
Collaborator

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all package URLs for package name consistency, one correction, others look good. Thanks Ryan!

README.md Show resolved Hide resolved
packages/web3-bzz/README.md Show resolved Hide resolved
packages/web3-core-method/README.md Outdated Show resolved Hide resolved
@holgerd77
Copy link
Collaborator

unit_and_e2e_clients test suite was failing, have retriggered.

@web3 web3 deleted a comment from azmain84 Apr 1, 2020
@cgewecke cgewecke self-requested a review April 6, 2020 17:36
Copy link
Collaborator

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ryanio ryanio merged commit d063437 into 1.x Apr 6, 2020
@evertonfraga evertonfraga deleted the addPackageReadmeBadges branch April 6, 2020 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants