Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify commitment to semantic versioning #3763

Closed
wants to merge 3 commits into from

Conversation

LudwikJaniuk
Copy link

see discussion in the issue #3758

@coveralls
Copy link

coveralls commented Oct 27, 2020

Coverage Status

Coverage remained the same at 78.053% when pulling 212fc52 on LudwikJaniuk:patch-1 into edf481d on ethereum:1.x.

Copy link
Contributor

@GregTheGreek GregTheGreek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg2m

will merge post RC.0

@github-actions
Copy link

This PR has been automatically marked as stale beacause it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label Dec 27, 2020
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot removed the Stale Has not received enough activity label Jan 8, 2021
Copy link

@koraykoska koraykoska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a +1 from me for this. We should really not introduce new breaking changes.

@spacesailor24 spacesailor24 added Documentation Relates to project wiki or documentation Enhancement Includes improvements or optimizations P3 Low severity bugs labels Mar 9, 2021
@coveralls
Copy link

coveralls commented Mar 16, 2021

Pull Request Test Coverage Report for Build 662051925

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 385 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-2.5%) to 73.759%

Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 88.0%
packages/web3-core-helpers/src/formatters.js 24 79.42%
packages/web3-core-helpers/src/errors.js 31 4.41%
packages/web3-utils/src/soliditySha3.js 55 5.56%
packages/web3-utils/src/index.js 60 30.0%
packages/web3-utils/src/utils.js 84 13.24%
packages/web3-eth-accounts/src/index.js 130 31.65%
Totals Coverage Status
Change from base Build 659174718: -2.5%
Covered Lines: 3292
Relevant Lines: 4223

💛 - Coveralls

@spacesailor24
Copy link
Contributor

Closing in favor of #3962, there was an update to how Infura links are provided to tests (#3943) and it seems to be causing an issue here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Relates to project wiki or documentation Enhancement Includes improvements or optimizations P3 Low severity bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants