Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hardcoded infura endpoints #3943

Merged
merged 6 commits into from
Mar 15, 2021
Merged

Replace hardcoded infura endpoints #3943

merged 6 commits into from
Mar 15, 2021

Conversation

spacesailor24
Copy link
Contributor

@spacesailor24 spacesailor24 commented Mar 10, 2021

Tests had hardcoded infura links, replaced them with Github Secrets

Includes #3950

@spacesailor24 spacesailor24 added Bug Addressing a bug P1 High severity bugs labels Mar 10, 2021
@spacesailor24 spacesailor24 added P0 Critical severity bugs and removed P1 High severity bugs labels Mar 12, 2021
@coveralls
Copy link

coveralls commented Mar 13, 2021

Pull Request Test Coverage Report for Build 647812351

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 226 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+2.5%) to 76.273%

Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 70.0%
packages/web3-core-helpers/src/formatters.js 8 82.27%
packages/web3-utils/src/utils.js 27 10.74%
packages/web3-core-helpers/src/errors.js 29 1.56%
packages/web3-utils/src/soliditySha3.js 34 3.92%
packages/web3-utils/src/index.js 42 32.12%
packages/web3-eth-accounts/src/index.js 85 33.06%
Totals Coverage Status
Change from base Build 555037995: 2.5%
Covered Lines: 3172
Relevant Lines: 3944

💛 - Coveralls

@spacesailor24 spacesailor24 merged commit 2c5a8ec into 1.x Mar 15, 2021
@spacesailor24 spacesailor24 deleted the wyatt/infura-link branch March 15, 2021 20:03
Copy link

@0racl3z 0racl3z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ive received so many questionable methods of this process its becoming more difficult to decide the validity of everyone. nonetheless, thank you all!

spacesailor24 added a commit that referenced this pull request Mar 26, 2021
* Replace hardcoded infura endpoints (#3943)

* Replace hardcoded infura endpoints

* infura link changelog

* WARNING Exposing secrets, rotate infura keys after debugging is finished

* Merging geth-dev-assistant updates (#3950)

* Bump geth-dev-assistant to 0.1.9

* npm i

* bump geth-dev-assistant

* Remove logs

* use posinstall to do deprecation warnings (#3917)

* use posinstall to do deprecation warnings

* add to change log

* add preinstall warning

* remove preinstall

* add warnings to bzz and shh package.json

Co-authored-by: Wyatt Barnes <wyatt@writerof.software>

* Bump elliptic from 6.5.3 to 6.5.4 in /packages/web3-eth-accounts (#3941)

Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4.
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](indutny/elliptic@v6.5.3...v6.5.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wyatt Barnes <wyatt@writerof.software>

* Bump elliptic from 6.5.3 to 6.5.4 in /packages/web3-bzz (#3940)

* Bump elliptic from 6.5.3 to 6.5.4 in /packages/web3-bzz

Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4.
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](indutny/elliptic@v6.5.3...v6.5.4)

Signed-off-by: dependabot[bot] <support@github.com>

* Update CHANGELOG

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wyatt Barnes <wyatt@writerof.software>
Co-authored-by: Wyatt Barnes <me@wyatt.email>

* Bump elliptic from 6.5.3 to 6.5.4 in /packages/web3-core-requestmanager (#3945)

* Bump elliptic from 6.5.3 to 6.5.4 in /packages/web3-core-requestmanager

Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4.
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](indutny/elliptic@v6.5.3...v6.5.4)

Signed-off-by: dependabot[bot] <support@github.com>

* Update CHANGELOG

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wyatt Barnes <me@wyatt.email>

* add nvmrc file (#3817)

* add nvmrc file

* Update changelog

Co-authored-by: Wyatt Barnes <wyatt@writerof.software>
Co-authored-by: Wyatt Barnes <me@wyatt.email>

* Rename tsc to compile (#3957) (#3958)

* Change 'tsc' command in scripts & lerna run to 'compile'

* Update changelog

* Undo incorrect rename

* Checking if e2e test is deterministic

Co-authored-by: Sam Hodak <slhodak@gmail.com>

Co-authored-by: Sam Hodak <slhodak@gmail.com>

* Debugging failing tests (#3959) (#3960)

* Remote node provider edits

* remote node provider documentation edits

Co-authored-by: smudgil <38195323+smudgil@users.noreply.github.com>

Co-authored-by: smudgil <38195323+smudgil@users.noreply.github.com>

* Clarify commitment to semantic versioning (#3961) (#3962)

see discussion in the issue #3758

Co-authored-by: LudwikJaniuk <ludvig.janiuk@gmail.com>

Co-authored-by: LudwikJaniuk <ludvig.janiuk@gmail.com>

* Feature/web3 eth iban es6 (#3964) (#3965)

* Feature/web3 eth iban es6 (#3964)

* web3-eth-iban es6 rewrite - replace `var` with `const` and `let`

* web3-eth-iban es6 rewrite - replace object prototype with class

* web3-eth-iban code style fix

Co-authored-by: Loredana <loredana.cirstea@gmail.com>

* Update changelog

Co-authored-by: Loredana <loredana.cirstea@gmail.com>

Co-authored-by: Frankie <frankie.diamond@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sam Hodak <slhodak@gmail.com>
Co-authored-by: smudgil <38195323+smudgil@users.noreply.github.com>
Co-authored-by: LudwikJaniuk <ludvig.janiuk@gmail.com>
Co-authored-by: Loredana <loredana.cirstea@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Addressing a bug P0 Critical severity bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants