Skip to content

Commit

Permalink
Correct json-rpc error code
Browse files Browse the repository at this point in the history
  • Loading branch information
reedsa committed Jul 25, 2023
1 parent 7bd708c commit ee911e3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions tests/core/providers/test_tester_provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def test_eth_tester_provider_properly_handles_eth_tester_key_error_messages():
provider = EthereumTesterProvider(api_endpoints={})
response = provider.make_request(RPCEndpoint("eth_blockNumber"), [])

assert response["error"]["code"] == -32000
assert response["error"]["code"] == -32601
assert isinstance(response["error"]["data"], KeyError)
assert response["error"]["message"] == "Unknown RPC Endpoint: eth_blockNumber"

Expand All @@ -84,7 +84,7 @@ def test_eth_tester_provider_properly_handles_eth_tester_not_implmented_error_me
provider = EthereumTesterProvider()
response = provider.make_request(RPCEndpoint("eth_blockNumber"), [])

assert response["error"]["code"] == -32000
assert response["error"]["code"] == -32601
assert isinstance(response["error"]["data"], NotImplementedError)
assert (
response["error"]["message"]
Expand Down
2 changes: 1 addition & 1 deletion web3/providers/eth_tester/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ def _error_response(error: str) -> RPCResponse:
"id": 1,
"jsonrpc": "2.0",
"error": {
"code": -32000,
"code": -32601,
"message": error,
"data": result,
},
Expand Down

0 comments on commit ee911e3

Please sign in to comment.