Add GethMiner snake case methods #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
reviewed
Feb 19, 2020
There was a problem hiding this comment.
Thank you for taking this on @billbsing! This is looking great. If you would, let's change all instances of camelCase methods to their snake_case equivalents unless we're explicitly testing for a deprecation warning. I noticed some instances of gasPrice still floating around, and there may be others that need to be switched too. I also added a few small comments, but nothing major. Let me know if you need more clarification!
docs/web3.miner.rst
Outdated
|
|
||
| .. py:method:: GethMiner.startAutoDAG() |
There was a problem hiding this comment.
This is existing, but we only have a startAutoDag method, not startAutoDAG. Do you mind changing?
Suggested change
| .. py:method:: GethMiner.startAutoDAG() | |
| .. py:method:: GethMiner.startAutoDag() |
kclowes
approved these changes
Feb 20, 2020
kclowes
force-pushed
the
billbsing/change-GethMiner-methods-to-snake-case
branch
from
887b0aa
to
21cc309
Compare
billbsing
deleted the
billbsing/change-GethMiner-methods-to-snake-case
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #1429
How was it fixed?
add new methods, and mark the current non snake case method names as depreciated.