Add Snake Case Methods for JSON-RPC calls

[kclowes]

What was wrong?

We'd like to start using pythonic snake_case names for all JSON-RPC methods. The pattern has been laid out in the Geth admin module.

How can it be fixed?

Add deprecation warnings, new snake case methods, and tests for all other modules. Ideally, each module would be its own PR.

• Eth
• GethShh
• GethPersonal
• GethTxPool
• GethMiner
• Net
• ParityShh
• ParityPersonal
• Parity

[Patil2099]

@kclowes Can You Explain it a bit more? I want to work on this issue!

[pipermerriam]

@Patil2099 see this PR #1326 which implements this in the geth admin module. You would follow the same pattern for the listed modules in this issue.

[Patil2099]

Thanks 😊 On Aug 22, 2019 10:07 PM, Piper Merriam <notifications@github.com> wrote: @Patil2099<https://github.com/Patil2099> see this PR #1326<#1326> which implements this in the geth admin module. You would follow the same pattern for the listed modules in this issue. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#1429?email_source=notifications&email_token=AIQAR5ES4HTJVFVYMJE2SGLQF26DXA5CNFSM4IOQLEY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD45VJNA#issuecomment-523982004>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AIQAR5BJXKWG6W2LDIFFA73QF26DXANCNFSM4IOQLEYQ>.

[Patil2099]

@kclowes I will start working on it.

[Patil2099]

@kclowes Do I have to do it like this?

[kclowes]

@kclowes Do I have to do it like this?

I'm not sure what you mean. Can you explain a little more?

We would prefer that you follow the implementation laid out in #1326, but we're open to hearing other ideas!

[Patil2099]

@kclowes should I start working on other modules?
Now I have a good example to follow.

[kclowes]

That would be great, thank you!

[smilegodly]

@kclowes I'd like to work on the GethPersonal module if that's ok ?

[kclowes]

@smilegodly that would be great, thanks! Let me know if you have any questions!

[smilegodly]

@kclowes
How can I individually run these tests here, so that I can see if the Deprecation Warnings get raised?


At the moment , I've just been using tox to test on the whole build structure.. but I would like to be able to run just what I need to be running to see that the deprecation warning tests are working fine .

I have figured out that I needed the pytest module and I am now able to run tests! :)

For some reason when testing the admin module the tests for that module (test node_info , test_addPeer...) are coming out as "SKIPPED".
Is there any reason for this happening.. How should I be properly testing these ?

[kclowes]

@smilegodly If you’re running the core tests, those use eth-tester and the skipped methods probably aren’t implemented in eth-tester. You might try running the integration tests. I think some of those are marked xfail, but the test should run and you may be able to check for a deprecation warning in the test anyway with a ‘with pytest.warns(DeprecationWarning, match=...)’. If that’s confusing I can expand more, just let me know!

[ashish10677]

Is this issue still open?

[kclowes]

@ashish10677 Yes it is! If you're going to work on one of the modules, please share which one here so we don't get two people working on the same thing! Thanks!

[billbsing]

If it's OK I would like to start on GethMiner.

[billbsing]

I'm working on the Net module

[tmckenzie51]

I'm working on the parity personal module

[billbsing]

If it's ok I would like to start working on the eth module start soon.

I assume @Patil2099 your last PR #1465 is not active anymore?

I'm planning to break it into several PRs since it's the bigger module.

• properties
• methods
• Move to ModuleV2 and the _utils/eth.py module ? (maybe a new issue for this?)

[kclowes]

Thanks @billbsing, but I've been working on moving the eth module to use ModuleV2, so hold off on that for a bit, otherwise I'll have some nasty merge conflicts! I'll let you know when I'm done if you still want to pick it up!

[wolovim]

pretty sure #1963 was the last of em 🎉 closing out.