Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate signTypedData in favor of sign_typed_data #1915

Merged

Conversation

tmckenzie51
Copy link
Contributor

@tmckenzie51 tmckenzie51 commented Mar 17, 2021

What was wrong?

added sign_typed_data, deprecated signTypedData

Related to Issue #1429

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@tmckenzie51 tmckenzie51 force-pushed the tiffany/signTypedData-to-snakecase branch from b36a0a3 to 1122619 Compare March 22, 2021 20:39
@tmckenzie51 tmckenzie51 changed the title Tiffany/sign typed data to snakecase deprecate signTypedData in favor of sign_typed_data Mar 29, 2021
@tmckenzie51 tmckenzie51 force-pushed the tiffany/signTypedData-to-snakecase branch from 5c7108f to 1d7fee9 Compare March 29, 2021 22:02
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I just left one nitpicky comment :) Feel free to take it or leave it and merge when you're ready!

docs/web3.eth.rst Outdated Show resolved Hide resolved
tmckenzie51 and others added 2 commits April 1, 2021 12:10
@tmckenzie51 tmckenzie51 merged commit 836996f into ethereum:master Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants