Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snake_case createFilter #2692

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Conversation

pacrob
Copy link
Contributor

@pacrob pacrob commented Oct 24, 2022

What was wrong?

createFilter was camelCase

How was it fixed?

Changed it to create_filter

Todo:

Cute Animal Picture

image

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥 looks good to me!

Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👌🏼

@pacrob pacrob merged commit a59bcb3 into ethereum:master Oct 24, 2022
@pacrob pacrob deleted the snake-case-createFilter branch October 24, 2022 22:39
@ignismeow
Copy link

Perfect now atleast we can differ between js and py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants