Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imported missing objects #2789

Closed
wants to merge 3 commits into from
Closed

Imported missing objects #2789

wants to merge 3 commits into from

Conversation

qraxiss
Copy link
Contributor

@qraxiss qraxiss commented Jan 24, 2023

What was wrong?

AsyncGethPersonal, AsyncGethAdmin objects are not imported.

How was it fixed?

I imported missing objects.

Todo:

Cute Animal Picture (My Dog 🥹)

@kclowes
Copy link
Collaborator

kclowes commented Jan 25, 2023

Aw, cute dogs! Thank you for flagging this! We actually shouldn't need to import those any more - all the modules should be loaded by default. Those lines (281-283) can be deleted if you're up for changing this PR?

@qraxiss
Copy link
Contributor Author

qraxiss commented Jan 25, 2023

web3.py docs
Website still old.

It has been modified in the Github documentation. AsyncEth, AsnyncGet, AsyncGethTxPool and Geth need to be deleted as they are not used(This is what I understand 🙃).

Do I have to throw a new PR for this or can this PR be changed?.

@kclowes
Copy link
Collaborator

kclowes commented Jan 25, 2023

Do I have to throw a new PR for this or can this PR be changed?

Feel free to update this PR, thank you! We have two versions of the documentation, one for v5 and one for v6 (called latest). The master branch corresponds to v6/latest, so you can just make the change in the master branch and it should show up in the latest documentation version. If you have the dev dependencies installed, you should be able to run make docs from the root of the project at the command line and see a preview of the docs.

@qraxiss
Copy link
Contributor Author

qraxiss commented Feb 2, 2023

I'm updated.

@kclowes kclowes mentioned this pull request Feb 16, 2023
1 task
@kclowes
Copy link
Collaborator

kclowes commented Feb 16, 2023

I'm not sure what happened with the lint here, and I wasn't able to quickly fix it so I cherry-picked your commit and opened another PR at #2820. You should still have credit for the commit on the new PR. Thanks for the contribution!

@kclowes kclowes closed this Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants