Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate miner namespace support and tests #2856

Closed
kclowes opened this issue Mar 1, 2023 · 2 comments
Closed

Deprecate miner namespace support and tests #2856

kclowes opened this issue Mar 1, 2023 · 2 comments

Comments

@kclowes
Copy link
Collaborator

kclowes commented Mar 1, 2023

What was wrong?

Geth removed support for their miner API since it's no longer needed after The Merge ™️ . See: https://geth.ethereum.org/docs/interacting-with-geth/rpc/ns-miner

How can it be fixed?

Add deprecation warnings to the methods within the miner namespace, and change the tests to check for the deprecation warnings. We can then either remove the methods as Geth stops supporting these, or wait until v7 to remove.

@reedsa reedsa added v7 breaking changes considered for v7 and removed v7 breaking changes considered for v7 labels Jan 10, 2024
@fselmo
Copy link
Collaborator

fselmo commented Mar 4, 2024

closed by #3236 (v7) and #3238 (v6)

@fselmo fselmo closed this as completed Mar 4, 2024
@molecula451
Copy link

what about chains that do still support "miner"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants