Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V6] Deprecate geth miner namespace #3238

Merged
merged 5 commits into from
Mar 4, 2024
Merged

[V6] Deprecate geth miner namespace #3238

merged 5 commits into from
Mar 4, 2024

Conversation

reedsa
Copy link
Contributor

@reedsa reedsa commented Feb 21, 2024

What was wrong?

Closes #2856

Geth removed support for their miner API.

How was it fixed?

Change GethMiner methods to DeprecatedMethod.

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@reedsa reedsa mentioned this pull request Feb 21, 2024
Closed
1 task
@reedsa reedsa mentioned this pull request Feb 21, 2024
Closed
pacrob
pacrob approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

kclowes
kclowes approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I left a question around the DeprecationWarning in the fixture generation, but looks good otherwise.

tests/integration/generate_fixtures/common.py Outdated Show resolved Hide resolved
tests/integration/generate_fixtures/go_ethereum.py Outdated Show resolved Hide resolved
@kclowes
Copy link
Collaborator

kclowes commented Feb 22, 2024

I also had to add docs/web3.providers.rpc.rst to the exclude_patterns in docs/conf.py but that is likely just me since the doc build is passing 🤷

reedsa
reedsa commented Feb 22, 2024
View reviewed changes
web3/method.py Outdated Show resolved Hide resolved
@reedsa reedsa merged commit 612a61f into ethereum:v6 Mar 4, 2024
99 checks passed
@fselmo fselmo mentioned this pull request Mar 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacrob pacrob pacrob approved these changes

@kclowes kclowes kclowes approved these changes

@fselmo fselmo Awaiting requested review from fselmo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@reedsa @kclowes @pacrob @e3243eric