Async sign and send raw middleware #3025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
force-pushed
the
async-sign-and-send-raw-middleware
branch
from
5a98a83
to
83b3a8a
Compare
- Copy the tests for sync over to async
- Don't assume some conversion is going to happen later down the line. The JSON-RPC asks for hexstr value, give it the hexstr value if we can guarantee that it is a hexstr. We already have the type as HexBytes so call ``.hex()`` on the value and send that as the param. - closes ethereum#2936
fselmo
force-pushed
the
async-sign-and-send-raw-middleware
branch
from
83b3a8a
to
de2f61a
Compare
reedsa
reviewed
Jul 6, 2023
| "value": 1, | ||
| "nonce": 0, | ||
| } | ||
| if isinstance(expected, type) and issubclass(expected, Exception): |
There was a problem hiding this comment.
Exceptions could be covered in a separate parameterized test, but really your preference here.
There was a problem hiding this comment.
Agreed, this is not ideal for new tests. I wanted to just copy the older sync cases so they can share the same test params but revamping both would be a good idea at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
closes #2773
closes #2936
closes #2937
How was it fixed?
Todo:
Cute Animal Picture