Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async sign and send raw middleware #3025

Merged
merged 4 commits into from Jul 6, 2023
Merged

Async sign and send raw middleware #3025

merged 4 commits into from Jul 6, 2023

Commits on Jul 6, 2023

  1. Add async support for sign_and_send_raw_middleware 

    - Copy the tests for sync over to async
    @fselmo
    fselmo committed Jul 6, 2023
    Copy the full SHA
    0a8ca6d View commit details
    Browse the repository at this point in the history

  2. Use HexBytes.hex() for sign-and-send-raw middlewares 

    - Don't assume some conversion is going to happen later down the line. The JSON-RPC asks for hexstr value, give it the hexstr value if we can guarantee that it is a hexstr. We already have the type as HexBytes so call ``.hex()`` on the value and send that as the param.
- closes ethereum#2936
    @fselmo
    fselmo committed Jul 6, 2023
    Copy the full SHA
    9a564bb View commit details
    Browse the repository at this point in the history

  3. Add relevant documentation for async sign-and-send-raw middleware

    @fselmo
    fselmo committed Jul 6, 2023
    Copy the full SHA
    de2f61a View commit details
    Browse the repository at this point in the history

  4. Add relevant newsfragments for ethereum#3025

    @fselmo
    fselmo committed Jul 6, 2023
    Copy the full SHA
    1b967e4 View commit details
    Browse the repository at this point in the history