New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert setup #1030
Convert setup #1030
Conversation
If all of my changes work, I believe I'll still need to update some docs. |
Something simple is wrong in |
The circleci error is connected to what is being discussed in #794 You are getting errors because pyethereum depends on rlp<1, and rlp>=1 is being installed. This PR exposes that issue by installing eth-testrpc as part of of the |
setup.py
Outdated
|
||
extras_require['dev'] = ( | ||
extras_require['tester'] + | ||
extras_require['testrpc'] + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this line should fix the failing tests.
…t and requirements-docs.txt in documentation and code
Removing the installation of eth-testrpc did not work, and I'm not sure now why pytest isn't being installed correctly |
Everything seems to be working fine now, I'm really not sure what the imports being incorrectly sorted problem is with the linter. |
Move the diff --git a/tox.ini b/tox.ini
index bc648ac..eebbf29 100644
--- a/tox.ini
+++ b/tox.ini
@@ -37,6 +37,7 @@ commands=
integration-parity-ws: pytest -s {posargs:tests/integration/parity/test_parity_ws.py}
doctest: make -C {toxinidir}/docs doctest
deps =
+ .[dev]
doctest: sphinx
doctest: ethtoken
passenv =
@@ -53,8 +54,6 @@ basepython =
py35: python3.5
py36: python3.6
py37: python3.7
-extras =
- dev
[testenv:lint]
basepython=python |
What was wrong?
Related to Issue #962
How was it fixed?
I got rid of the requirements .txt files, updated setup.py, tox.ini, and Dockerfile
Cute Animal Picture