Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory leak fix #1138

Merged
merged 1 commit into from Nov 15, 2018
Merged

memory leak fix #1138

merged 1 commit into from Nov 15, 2018

Conversation

MichaelRazum
Copy link
Contributor

removed _function_names and _event_names

ContractEvents and ContractFunctions have not used lists _event_names / _function_names.
Each time a contract is created through the factory method, the _event_names list and the _function_names list are extended.
Creating many contract's results in high memory usage.

(cherry picked from commit 94b8b40)

What was wrong?

Related to Issue #

How was it fixed?

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

removed _function_names and _event_names

ContractEvents and ContractFunctions have not used lists _event_names / _function_names.
Each time a contract is created through the factory method, the _event_names list and the _function_names list are extended.
Creating many contract's results in high memory usage.

(cherry picked from commit 94b8b40)
@kclowes
Copy link
Collaborator

kclowes commented Nov 15, 2018

Looks great, thanks!

@kclowes kclowes merged commit 26a3235 into ethereum:v4 Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants