Drop web3.providers.tester.py (V5 beta) #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
changed the title
njgheorghita
force-pushed
the
drop-web3-providers-tester
branch
from
6ea4ef2
to
36854aa
Compare
njgheorghita
requested review from
carver,
pipermerriam and
kclowes
and removed request for
carver
pipermerriam
approved these changes
Jan 11, 2019
| @@ -17,7 +17,8 @@ Read more in the [documentation on ReadTheDocs](http://web3py.readthedocs.io/). | |||
| import json | |||
| import web3 | |||
|
|
|||
| from web3 import Web3, HTTPProvider, TestRPCProvider | |||
There was a problem hiding this comment.
We should probably remove this entire section from the README in favor of just using RTD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Removed
web3.providers.tester.EthereumTesterProviderandweb3.providers.tester.TestRPCProvideras specified in the issue.Related to Issue #1027
How was it fixed?
web3/providers/tester.pyCute Animal Picture