Update docs for block_count arg #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
force-pushed
the
fee-history-docs
branch
from
02910a1
to
3c7f017
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
There is some standardization lacking between clients in regards to the type of the
block_countargument foreth.feeHistoryRPC Method. In the next release Geth will accept a hexstring for theblock_countargument, but some other clients only allow ints.Related to Issue: ethereum/execution-apis#20
How was it fixed?
Added some docs to clarify that
block_countmay either take a hexstring or an int, depending on the client. @fselmo - let me know if you think this needs more/better/different clarification!Todo:
Cute Animal Picture