Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContractFunctions.__getitem__ type hint bugfix #2275

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

abcdabcd987
Copy link

The item is defined by setattr at Line 166, which is a ContractFunction.

abcdabcd987 and others added 2 commits December 23, 2021 00:13
The item is defined by `setattr` at Line 166, which is a `ContractFunction`.
@abcdabcd987
Copy link
Author

@kclowes Hi, It seems that the CI tests were cancelled. Can you rerun it?

@abcdabcd987
Copy link
Author

@kclowes CI tests have passed. Could you review the change and merge the PR? It fixes type check and code autocompletion for my_contract.functions["foo"], which should behave the same as my_contract.functions.foo.

@kclowes
Copy link
Collaborator

kclowes commented Jan 28, 2022

I will put this in our queue to review. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants