Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for custom methods for modules #2383

Merged
merged 4 commits into from Mar 10, 2022

Commits on Mar 8, 2022

  1. Configuration menu
    Copy the full SHA
    d273818 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dd5bd98 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2022

  1. Add option to attach methods to classes extending from Module class

    * Refactor logic for attaching a `Method` class as a property rather than a method. Instead of implicitly setting `mungers=None`, explicitly set the `is_property` flag on `Method` to `True`. This also facilitates attaching new methods and properties to modules.
    
    * Fix up some tests in test_method.py that were falsely passing to actually test correctly. Add tests for new `is_property` flag for the `Method` class.
    
    * Create `test_module.py` and add tests for `attach_methods()`
    fselmo committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    e6f306c View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2022

  1. Configuration menu
    Copy the full SHA
    cb6b4a0 View commit details
    Browse the repository at this point in the history