add docs for attach_methods #2465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolovim
force-pushed
the
docs-attach-methods
branch
from
ee619bf
to
93ec8a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Commit 7762ed9 introduced
attach_methods, enabling custom methods to be added to modules or override existing ones. This hasn't made it into the docs yet.Note that this feature will not be backported to v5.
I don't see a good natural home for this documentation, so just adding a brief description to the top-level
Web3 APIpage with the intention of creating a newCustomizing Web3.pypage that will include Custom Methods, External Modules, and Middleware(, oh my).Todo:
Cute Animal Picture