Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snakecase encoding decoding helpers #2707

Merged

Conversation

linda-le1
Copy link
Contributor

@linda-le1 linda-le1 commented Nov 3, 2022

What was wrong?

Inherited javascript syntax. This PR does not include a deprecation step, intended for v6.
Related to Issue #2598

How was it fixed?

Changed toBytes to to_bytes, toHex to to_hex, toInt to to_int, toJSON to to_json, and toText to to_text.

Todo:

Cute Animal Picture

hedgehog

@linda-le1 linda-le1 force-pushed the snakecase-encoding-decoding-helpers branch from c5e505f to d071d4a Compare November 3, 2022 05:18
@linda-le1 linda-le1 marked this pull request as ready for review November 3, 2022 05:32
@linda-le1
Copy link
Contributor Author

@kclowes @pacrob @fselmo All set for a PR review - thank you!

Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🎉

Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kclowes kclowes merged commit a8e6b48 into ethereum:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants