Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: release async lock only if locked #3083

Merged
merged 1 commit into from
Aug 22, 2023
Merged

bugfix: release async lock only if locked #3083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions newsfragments/3083.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Only release ``async_lock`` if it's locked to begin with.
3 changes: 2 additions & 1 deletion web3/_utils/async_caching.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,5 @@ async def async_lock(
await loop.run_in_executor(thread_pool, lock.acquire)
yield
finally:
lock.release()
if lock.locked():
lock.release()