Validate geth version in test fixture against binary used for tests #3193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
We've had instances where we forget to update the
geth
version being used in the circleCI runs and this goes unnoticed since two versions can be compatible with each other. This means we create the fixture with one version, but run it with another - and, as long as no noticeable changes have happened, this is silently unintended.How was it fixed?
Todo:
Cute Animal Picture