Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return input instead of data for EthereumTesterProvider (eth_getTransaction*) #3235

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Feb 21, 2024

What was wrong?

closes #901

Todo:

Cute Animal Picture

Screenshot 2024-02-21 at 13 45 01

@fselmo fselmo marked this pull request as ready for review February 21, 2024 20:40
@fselmo fselmo changed the title Return input instead of data for EthereumTesterProvider (eth_getTransaction) Return input instead of data for EthereumTesterProvider (eth_getTransaction*) Feb 21, 2024
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fselmo fselmo merged commit f74dfa8 into ethereum:main Feb 21, 2024
81 checks passed
@fselmo fselmo deleted the eth-tester-data-to-input branch February 21, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web3.eth.getTransaction with EthereumTesterProvider return data instead of input
2 participants