feature: add RPC eth_getBlockReceipts #3247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
reviewed
Feb 23, 2024
| @@ -642,11 +642,32 @@ def test_eth_getBlockByNumber_finalized( | |||
| ) -> None: | |||
| super().test_eth_getBlockByNumber_finalized(w3, empty_block) | |||
|
|
|||
| def test_eth_fee_history(self, w3: "Web3") -> None: | |||
| super().test_eth_fee_history(w3) | |||
| def test_eth_getBlockReceipts_hash( | |||
There was a problem hiding this comment.
Since we don't have eth_getBlockReceipts implemented in eth-tester, we'll need to add these tests to the not_implemented section that's closer to the beginning of this file.
There was a problem hiding this comment.
Excuse me, may I ask if this is the change? It seems that even after the change here, it has not taken effect
There was a problem hiding this comment.
Thanks for the ping. Now that you are listing the tests as not_implemented above, you can delete them here and the tests should pass.
|
I don't think this is failing due to anything you added, @jsvisa. I'll see if I can straighten it out. Thanks! |
kclowes
force-pushed
the
eth_getBlockReceipts
branch
from
b65a436
to
0d83c74
Compare
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
kclowes
force-pushed
the
eth_getBlockReceipts
branch
from
1576a28
to
8b56d40
Compare
kclowes
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #2004
How was it fixed?
eth_getBlockReceiptswas introduced in the standard RPC ethereum/execution-apis#438, we can simply implement itTodo:
Cute Animal Picture