Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eth-utils to v4.0.0 #3248

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Update eth-utils to v4.0.0 #3248

merged 3 commits into from
Feb 27, 2024

Conversation

reedsa
Copy link
Contributor

@reedsa reedsa commented Feb 23, 2024

What was wrong?

Closes #715

How was it fixed?

Major version bump of eth-utils to make Web3.is_address return True for non-checksummed addresses.

Todo:

Cute Animal Picture

Screen Shot 2024-02-23 at 9 08 36 AM

reedsa added a commit to reedsa/web3.py that referenced this pull request Feb 26, 2024
@pacrob
Copy link
Contributor

pacrob commented Feb 27, 2024

I think your newsfragments got crossed 😁

Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, w/ an updated newsfragment!

@reedsa reedsa merged commit 0e08805 into ethereum:main Feb 27, 2024
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web3.isAddress doesn't work for non prefixed checksumed values
3 participants