ContractCaller initializes without validating the block_identifier
#3257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reedsa
added a commit
to reedsa/web3.py
that referenced
this pull request
Feb 26, 2024
reedsa
force-pushed
the
contract-caller-block-id
branch
from
da6820a
to
31750c2
Compare
reedsa
added a commit
to reedsa/web3.py
that referenced
this pull request
Feb 26, 2024
reedsa
force-pushed
the
contract-caller-block-id
branch
from
31750c2
to
eac6e99
Compare
fselmo
approved these changes
Feb 27, 2024
reedsa
force-pushed
the
contract-caller-block-id
branch
from
eac6e99
to
30f4155
Compare
|
@fselmo Good catch, added those in and cleaned up those tests a bit more. |
|
Sounds good. Ship it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Closes #2816
How was it fixed?
Remove call to
parse_block_identifierwhen initializingContractCallerfunctions. The validation occurs when calling the function itself.Todo:
Cute Animal Picture