Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ethpm #3261

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Remove ethpm #3261

merged 4 commits into from
Mar 7, 2024

Conversation

pacrob
Copy link
Contributor

@pacrob pacrob commented Mar 1, 2024

What was wrong?

ethpm was deprecated, now being fully removed.

Related to Issue #2854

Todo:

Cute Animal Picture

image

@pacrob pacrob force-pushed the remove-ethpm branch 4 times, most recently from abf72f0 to 49b84c6 Compare March 1, 2024 20:12
@pacrob pacrob marked this pull request as ready for review March 1, 2024 20:19
@pacrob pacrob requested review from kclowes, fselmo and reedsa March 1, 2024 20:19
@pacrob pacrob mentioned this pull request Mar 6, 2024
Copy link
Contributor

@reedsa reedsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Does this removal require any user docs for migrating away from ethpm?

@pacrob
Copy link
Contributor Author

pacrob commented Mar 7, 2024

Does this removal require any user docs for migrating away from ethpm?

i don't believe there are any current users (it's been borked for ~18 mos), but good reminder to at least put a note in the migration guide. Done!

Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-13k... love that. lgtm 👍🏼

@pacrob pacrob merged commit 257f464 into ethereum:main Mar 7, 2024
81 checks passed
@pacrob pacrob deleted the remove-ethpm branch March 7, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants