Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated personal namespace #3350

Merged
merged 8 commits into from
Apr 17, 2024
Merged

Remove deprecated personal namespace #3350

merged 8 commits into from
Apr 17, 2024

Commits on Apr 16, 2024

  1. Remove the deprecated personal namespace and references to it.

    @fselmo
    fselmo committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    d581f8e View commit details
    Browse the repository at this point in the history

  2. Fix up integration tests after removing personal namespace: 

    - Remove the idea of an ``unlockable_account``. Since we are no longer
  using an API to "unlock", there's no need to test it. Instead, use
  the keyfile account as the ``from`` in ``eth_sendTransaction`` and
  anywhere that an account that is "known" by the node needs to be used.

- Set up the keyfile account as the known account for testing.
    @fselmo
    fselmo committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    677b3a8 View commit details
    Browse the repository at this point in the history

  3. Update codebase to use newly generated fixture v1.13.14

    @fselmo
    fselmo committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    9b60336 View commit details
    Browse the repository at this point in the history

  4. Remove flaky test runs related to unlocking / locking account

    @fselmo
    fselmo committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    93ca73d View commit details
    Browse the repository at this point in the history

  5. Fix up raw transaction tests; use keyfile acct pkey

    @fselmo
    fselmo committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    f954e72 View commit details
    Browse the repository at this point in the history

  6. Make old contract state test more stable

    @fselmo
    fselmo committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    a6aac72 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Last bit of personal namespace cleanup; newsfragment for ethereum#3350 

    - Clean up some unnecessary changes related to removing personal namespace
- bonus: re-generate fixture for making sure we have all changes in related to ethereum#3350
    @fselmo
    fselmo committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    68e7e3b View commit details
    Browse the repository at this point in the history

  2. Remove funded_account_for_raw_txn in favor of keyfile_account_address

    @fselmo
    fselmo committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    71407ca View commit details
    Browse the repository at this point in the history