add py312 support - v6 #3373
Merged
add py312 support - v6 #3373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reedsa
reviewed
May 2, 2024
| ) | ||
| from typing import Dict # noqa: F401 |
There was a problem hiding this comment.
Was there a limit your for dict? Weird that it imports typing twice
There was a problem hiding this comment.
Not sure. I put the noqa line after it in the original single import and something in linting split it out. Maybe isort?
There was a problem hiding this comment.
I think you can say: self.strategies: Dict[str, Callable[[Package], Package]] = {} on line 30 below and get rid of this weird import stuff
kclowes
approved these changes
May 2, 2024
| ) | ||
| from typing import Dict # noqa: F401 |
There was a problem hiding this comment.
I think you can say: self.strategies: Dict[str, Callable[[Package], Package]] = {} on line 30 below and get rid of this weird import stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Support py312 in v6. Bumped
flake8version to one that supports py312, fixed a couple errors that came up.Todo:
Cute Animal Picture