Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: eth_subscribe api, misc. cleanup #3386

Merged
merged 5 commits into from
May 13, 2024

Conversation

wolovim
Copy link
Member

@wolovim wolovim commented May 9, 2024

What was wrong?

  • eth_subscribe and eth_unsubscribe not yet listed in API; this is a simple v1 that points to the persistent connection provider docs for usage examples.
  • bonus: shuffling around the contract examples a bit
  • bonus: make a transaction type warning more generic and moves it to the Troubleshooting guide
  • bonus: update a reference to more recent WebSocketProvider blog post

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@wolovim wolovim requested review from fselmo and kclowes and removed request for fselmo May 10, 2024 15:53
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me 👍🏼... nothing blocking at all, just food for thought.

docs/troubleshooting.rst Outdated Show resolved Hide resolved
docs/web3.contract.rst Outdated Show resolved Hide resolved
docs/web3.eth.rst Outdated Show resolved Hide resolved
docs/web3.eth.rst Outdated Show resolved Hide resolved
docs/troubleshooting.rst Outdated Show resolved Hide resolved
docs/web3.contract.rst Outdated Show resolved Hide resolved
docs/web3.eth.rst Outdated Show resolved Hide resolved
wolovim and others added 4 commits May 10, 2024 12:30
Co-authored-by: felipe <fselmo2@gmail.com>
Co-authored-by: felipe <fselmo2@gmail.com>
Co-authored-by: felipe <fselmo2@gmail.com>
@wolovim wolovim merged commit b2f5574 into ethereum:main May 13, 2024
71 checks passed
@wolovim wolovim deleted the docs-cleanup-part-n branch May 13, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants