Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: introduce batch requests #3393

Merged
merged 4 commits into from
May 15, 2024
Merged

Conversation

wolovim
Copy link
Member

@wolovim wolovim commented May 14, 2024

What was wrong?

batch_requests api needs documenting

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@wolovim wolovim requested a review from fselmo May 14, 2024 20:23
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Left some nits but really I'm even thinking too hard about them I think... take or leave.

docs/web3.main.rst Outdated Show resolved Hide resolved
docs/web3.main.rst Outdated Show resolved Hide resolved
docs/web3.main.rst Outdated Show resolved Hide resolved
@fselmo
Copy link
Collaborator

fselmo commented May 14, 2024

Oh, it will be important to capture the async functionality as well since the await is not required when adding requests to the batch. However, when executing, it will need to be awaited via await batch.async_execute().

wolovim and others added 3 commits May 15, 2024 09:58
Co-authored-by: felipe <fselmo2@gmail.com>
Co-authored-by: felipe <fselmo2@gmail.com>
@wolovim wolovim merged commit 3019f72 into ethereum:main May 15, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants