-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event ABI Utilities #3401
Draft
reedsa
wants to merge
17
commits into
ethereum:main
Choose a base branch
from
reedsa:abi-event-utils
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Event ABI Utilities #3401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
reedsa
changed the title
ABI Event Utils
ABI Event Utils - Initial cleanup of May 17, 2024
get_event_data
reedsa
added a commit
to reedsa/web3.py
that referenced
this pull request
May 20, 2024
reedsa
added a commit
to reedsa/web3.py
that referenced
this pull request
May 21, 2024
reedsa
changed the title
ABI Event Utils - Initial cleanup of
Event ABI Utilities
May 23, 2024
get_event_data
This was referenced May 30, 2024
reedsa
added a commit
to reedsa/web3.py
that referenced
this pull request
May 31, 2024
reedsa
added a commit
to reedsa/web3.py
that referenced
this pull request
May 31, 2024
reedsa
added a commit
to reedsa/web3.py
that referenced
this pull request
Jun 3, 2024
reedsa
force-pushed
the
abi-event-utils
branch
2 times, most recently
from
June 3, 2024 19:47
72197f6
to
40c6e4b
Compare
Add contract fixture
Revert test fixture
Replaces `ABI`, `ABIEvent`, `ABIEventParams, `ABIFunction`, and `ABIFunctionParams`. Use correct `ABIComponent` or `ABIComponentIndexed` in place of `ABIFunctionParams` and `ABIEventParams`.
Deprecate `get_abi_input_names` and `get_abi_input_names`.
Types are now referenced from `eth_typing` and relevant ABI utils moved to `eth-utils`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #1596, #3036
Dependent on ethereum/eth-utils#271
Before exposing
get_event_data
, refactoring and cleanup is needed. A couple of utilities can be created to get log topics (as bytes) for a given event ABI.How was it fixed?
Utilities added to handle contract event ABIs,
get_event_log_topics
andlog_topic_to_bytes
.Todo:
Cute Animal Picture