Add deprecation of eth-typing.ethpm types to the migration guide.
#3413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
EthPM is removed in v7 and the types in
eth-typingshould also be removed. Before removal, the types should be deprecated. Thedeprecateddecorator doesnt work for variable or type declarations so just documenting them as deprecated should be sufficient.Related to ethereum/eth-typing#67
How was it fixed?
This adds info to the
EthPMsection about the deprecation and future removal of type declarations forContractName,ManifestandURI.Todo:
Cute Animal Picture