Fix Beacon API after internal cache rehaul: #3421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
force-pushed
the
fix-beacon-after-cache-rehaul
branch
from
7e36dc4
to
3568447
Compare
- We moved session caching as internal parts of HTTP providers. Since that change, the ``Beacon`` API was receiving a bad bath for session caching. These updated fix that and raise the timeout for the async tests since some seem to be timing out.
fselmo
force-pushed
the
fix-beacon-after-cache-rehaul
branch
from
3568447
to
8a6ccb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
We moved session caching as internal parts of HTTP providers. Since that change, the
BeaconAPI was receiving a bad bath for session caching.How was it fixed?
These updates fix that (by setting the proper path to the
HTTPSessionManagerclass) and raise the timeout for the async tests since some seem to be timing out.Todo:
Cute Animal Picture