Restore links directly to Github master #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YazzyYaz
suggested changes
Jun 29, 2019
There was a problem hiding this comment.
Sorry, I'm not following why we need this PR. We merged the ECIPs site in, the ECIP markdown is preserved as before.
If some people are upset about this who aren't developers to begin with, maybe the way to resolve such motions is via educating better on what we did on a technical level? Otherwise, I feel it's a loss in translation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores links to Github master. However, IMO we should only preserve permalinks to
ecips.ethereumclassic.org, and if people are linking to Github directly, they should link towards particular revisions.Note that because we're not using collections, additional attribute
lang: enis required for all ECIP files.