Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ECIP-1049 "Keccak256" to Last Call #354

Merged
merged 1 commit into from
Aug 30, 2020
Merged

Move ECIP-1049 "Keccak256" to Last Call #354

merged 1 commit into from
Aug 30, 2020

Conversation

q9f
Copy link
Contributor

@q9f q9f commented Aug 28, 2020 •
edited
Loading

as per #333

together with #355

there will be a working group for SHA3 and Keccak256 formed asap, action items:

  • working group to merge these proposals (Stevan & Alex)
  • figure out and specify a proper transition from Ethash to the new algorithm

also, specifically, ECIP-1049 needs a lot of text work, please follow the ECIP-X template file.

@q9f q9f added type: std-core ECIPs of the type "Core" - changing the Classic protocol. status:5 last-call ECIP has been accepted and is waiting for last-call reviews. editor:5 needs-review This contribution needs a careful review. labels Aug 28, 2020
This was referenced Aug 28, 2020
Merged
Closed
mikeyb
mikeyb approved these changes Aug 29, 2020
View reviewed changes
Copy link
Member

@mikeyb mikeyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TheEnthusiasticAs TheEnthusiasticAs merged commit 821e489 into master Aug 30, 2020
@q9f q9f deleted the q9-sha3-256 branch August 31, 2020 07:14
@q9f q9f added editor:7 looks-good This contribution is well reviewed and good to be merged. and removed editor:5 needs-review This contribution needs a careful review. labels Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeyb mikeyb mikeyb approved these changes

@TheEnthusiasticAs TheEnthusiasticAs TheEnthusiasticAs approved these changes

Assignees
No one assigned
Labels
editor:7 looks-good This contribution is well reviewed and good to be merged. status:5 last-call ECIP has been accepted and is waiting for last-call reviews. type: std-core ECIPs of the type "Core" - changing the Classic protocol.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@q9f @mikeyb @TheEnthusiasticAs