Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rules #32

Merged
merged 26 commits into from
Oct 22, 2022
Merged

Add Rules #32

merged 26 commits into from
Oct 22, 2022

Conversation

IstoraMandiri
Copy link
Collaborator

Fixes #18 , please review and make suggestions.

ghost
ghost previously requested changes Oct 16, 2022
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal of line 53 -> 58

This is content for @ETC_Network imho

@IstoraMandiri
Copy link
Collaborator Author

Looks like @bobsummerwill agrees with you @w1g0

https://twitter.com/BobSummerwill/status/1581633468441976836

Very unlikely. The account is NOT for promotion of specific projects. The website is there as a directory for people to find things.

I wonder if there are limits to this though - what about the examples given in the comments above?

@ghost
Copy link

ghost commented Oct 16, 2022

Didn't check the tweets, and examples are "coming soon", so which ones are you referring to?

@IstoraMandiri
Copy link
Collaborator Author

Perhaps you missed it because I created it as part of a review. I'll stick to regular comments from now.

I figured this one would be controversial, but the reasoning I have it like this is that I think that it becomes difficult to draw a line. Should this account really never tweet out third party projects?

If Mantis or Besu had a release or security problem, should ignore that?

If MetaMask decided to support ETC by default,, we should not tweet this?

What if an ETC ETF was launched by Greyscale?

Perhaps a compromise would be that this account is not used for small projects, but only big projects such as the examples given?

@ghost
Copy link

ghost commented Oct 16, 2022

Projects from small lesser known project must be linked to via the website, which includes a disclaimer, must include a disclaimer within the tweet.

None of these are small projects. Exceptions to larger known projects seems reasonable to retweet with text.

@IstoraMandiri
Copy link
Collaborator Author

IstoraMandiri commented Oct 16, 2022

@w1g0 cool, let's update that then.

"Large" should would be those projects that have been around for at least 2 years and likely to be known about by most people following ETC. ?

@ghost
Copy link

ghost commented Oct 16, 2022

Line 57 "Tether-ETC" maybe better to put "ETC/Tether"
it's very unlikely that Binance will use ETC as denominator ^^

@IstoraMandiri
Copy link
Collaborator Author

By Tether-ETC I meant a version of Tether deployed to ETC.

@ghost
Copy link

ghost commented Oct 16, 2022

(e.g. Binance listing TetherETC/ETC pair, ...

(e.g. Binance listing USDT Tether tokens on the ETC blockchain, ...

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not in favor of the crediting system mentioned in line 70

@ghost ghost requested review from bobsummerwill and brolal October 19, 2022 23:20
Copy link
Member

@TheCrowbill TheCrowbill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several minor usage and syntax errors throughout the new text.

Instead of listing them all here individually, may I edit the file directly?

@IstoraMandiri
Copy link
Collaborator Author

There are several minor usage and syntax errors throughout the new text.

Instead of listing them all here individually, may I edit the file directly?

Yes, please do!

IstoraMandiri and others added 4 commits October 21, 2022 07:15
Fixes many grammatical, usage and syntax errors.

Some sentence structure revision and additions for added clarity.
`eth_classic` --> `@eth_classic' in four instances
Fixed typo
@TheCrowbill
Copy link
Member

There are several minor usage and syntax errors throughout the new text.
Instead of listing them all here individually, may I edit the file directly?

Yes, please do!

Done.

@TheCrowbill TheCrowbill requested review from a user and TheCrowbill October 21, 2022 06:26
@IstoraMandiri
Copy link
Collaborator Author

Awesome, thank you @TheCrowbill !

Copy link

@justjinn justjinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Very well written.

  • Under new project announcements, may want to add a line or something to minimize scam potential (how will the scam-o-meter be gauged).

  • Also may want to add something about new nft project announcements (remembering the time when ETC NFTs started to populate and eth_classic was getting heat for not promoting all NFTs).

Thinking out loud.
💚

Copy link
Member

@TheCrowbill TheCrowbill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, this is ready to merge and any changes needed going forward can be done from there.

@IstoraMandiri
Copy link
Collaborator Author

IMO, this is ready to merge and any changes needed going forward can be done from there.

Agree, please help merge this @ethereumclassic/tweeters .

Removed Third Party Projects section as requested by @w1g0 .

Copied for inclusion in @ETH_Network rules.
@IstoraMandiri
Copy link
Collaborator Author

IstoraMandiri commented Oct 22, 2022

@TheCrowbill please could you undo the removal third parties?

@w1g0 mentioned above that it's reasonable for large projects such as those in the examples.

At least, please lets discuss this further updates in this thread.

Stick to this experiment in the other repo for now.
@TheCrowbill
Copy link
Member

Yes.

If resolved, why are the requested changes still blocking merge?

Replacing Third Party Projects section.
@TheCrowbill
Copy link
Member

Third Party Projects section has been replaced without alteration.

Copy link
Member

@TheCrowbill TheCrowbill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, this is ready for merge.

@IstoraMandiri
Copy link
Collaborator Author

IstoraMandiri commented Oct 22, 2022

Thanks @TheCrowbill, and yep, just need one more approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Draft rules for tweet contents
4 participants