-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rules #32
Add Rules #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removal of line 53 -> 58
This is content for @ETC_Network imho
Looks like @bobsummerwill agrees with you @w1g0 https://twitter.com/BobSummerwill/status/1581633468441976836
I wonder if there are limits to this though - what about the examples given in the comments above? |
Didn't check the tweets, and examples are "coming soon", so which ones are you referring to? |
Perhaps you missed it because I created it as part of a review. I'll stick to regular comments from now.
|
None of these are small projects. Exceptions to larger known projects seems reasonable to retweet with text. |
@w1g0 cool, let's update that then. "Large" should would be those projects that have been around for at least 2 years and likely to be known about by most people following ETC. ? |
Line 57 "Tether-ETC" maybe better to put "ETC/Tether" |
By Tether-ETC I meant a version of Tether deployed to ETC. |
(e.g. Binance listing USDT Tether tokens on the ETC blockchain, ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still not in favor of the crediting system mentioned in line 70
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several minor usage and syntax errors throughout the new text.
Instead of listing them all here individually, may I edit the file directly?
Yes, please do! |
Fixes many grammatical, usage and syntax errors. Some sentence structure revision and additions for added clarity.
`eth_classic` --> `@eth_classic' in four instances
Fixed typo
Done. |
Awesome, thank you @TheCrowbill ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Very well written.
-
Under new project announcements, may want to add a line or something to minimize scam potential (how will the scam-o-meter be gauged).
-
Also may want to add something about new nft project announcements (remembering the time when ETC NFTs started to populate and eth_classic was getting heat for not promoting all NFTs).
Thinking out loud.
💚
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, this is ready to merge and any changes needed going forward can be done from there.
Agree, please help merge this @ethereumclassic/tweeters . |
Removed Third Party Projects section as requested by @w1g0 . Copied for inclusion in @ETH_Network rules.
@TheCrowbill please could you undo the removal third parties? @w1g0 mentioned above that it's reasonable for large projects such as those in the examples. At least, please lets discuss this further updates in this thread. |
Stick to this experiment in the other repo for now.
Yes. If resolved, why are the requested changes still blocking merge? |
Replacing Third Party Projects section.
Third Party Projects section has been replaced without alteration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK, this is ready for merge.
Thanks @TheCrowbill, and yep, just need one more approval. |
Fixes #18 , please review and make suggestions.