Check for Buffer in rawDecode

ethereumjs · Mar 5, 2019 · ff783d8 · ff783d8
1 parent d84a967
commit ff783d8
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 0 deletions.
diff --git a/.gitignore b/.gitignore
@@ -25,3 +25,6 @@ build/Release
 # Dependency directory
 # https://www.npmjs.org/doc/misc/npm-faq.html#should-i-check-my-node_modules-folder-into-git
 node_modules
+
+# IDE
+.idea
diff --git a/lib/index.js b/lib/index.js
@@ -381,6 +381,11 @@ ABI.rawEncode = function (types, values) {
 
 ABI.rawDecode = function (types, data) {
   var ret = []
+
+  if (!Buffer.isBuffer(data)) {
+    throw new Error('expect data to be Buffer')
+  }
+
   data = new Buffer(data)
   var offset = 0
   for (var i = 0; i < types.length; i++) {

diff --git a/test/index.js b/test/index.js
@@ -196,6 +196,16 @@ it('decoding address with leading 0', function () {
 
 // Homebrew decoding tests
 
+describe('decoding non-Buffer', function () {
+  it('should throw error', function () {
+    try {
+      abi.rawDecode([ 'uint32' ], 'hello')
+    } catch (error) {
+      assert.equal(error.message, 'expect data to be Buffer')
+    }
+  })
+})
+
 describe('decoding uint32', function () {
   it('should equal', function () {
     var a = abi.rawDecode([ 'uint32' ], new Buffer('000000000000000000000000000000000000000000000000000000000000002a', 'hex'))