Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serpent overhaul: fix string types #18

Merged
merged 2 commits into from
Jun 4, 2016
Merged

Serpent overhaul: fix string types #18

merged 2 commits into from
Jun 4, 2016

Conversation

axic
Copy link
Member

@axic axic commented Jun 1, 2016

As discussed with @tinybike, the s type in Serpent actually support arbitrary binary data. Mapping it to string here would cause it to be processed as UTF8 possibly resulting in invalid output.

With using bytes the caller must make sure to encode using UTF8 if needed by supplying the result of new Buffer("hello", 'utf8') as the input.

Fixes #15 #16.

@coveralls
Copy link

coveralls commented Jun 1, 2016

Coverage Status

Coverage decreased (-14.9%) to 66.699% when pulling 8706e93 on patch/serpent-fixes into 0d17bad on master.

@tinybike
Copy link
Member

tinybike commented Jun 4, 2016

Beautifully done, @axic!

@tinybike tinybike merged commit 43c2d80 into master Jun 4, 2016
@axic axic deleted the patch/serpent-fixes branch June 4, 2016 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants