Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @tinybike, the
s
type in Serpent actually support arbitrary binary data. Mapping it tostring
here would cause it to be processed as UTF8 possibly resulting in invalid output.With using
bytes
the caller must make sure to encode using UTF8 if needed by supplying the result ofnew Buffer("hello", 'utf8')
as the input.Fixes #15 #16.